fix: Http proxy CORS problem, Keep origin by default. #10699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #10699 +/- ##
=======================================
Coverage 28.90% 28.90%
=======================================
Files 458 458
Lines 13653 13653
Branches 3201 3201
=======================================
Hits 3946 3946
- Misses 9024 9025 +1
+ Partials 683 682 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xiaohuoni
approved these changes
May 12, 2023
xierenyuan
approved these changes
May 12, 2023
sorrycc
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10692
我修改了一下这段代码，默认情况下不修改Header中的Origin字段，以避免CORS问题
在开启changeOrigin的情况下，http-proxy库会修改Header中的host字段，但是不会修改Origin字段，所以也会导致CORS问题
我加了个判定，changeOrigin开启的时候，修改Origin字段。 这样做既可以让changeOrgin这个控制参数更符合预期，同时避免了CORS问题
修改之后的changeOrigin行为：
两种模式都不会有CORS问题